Skip to content
This repository has been archived by the owner on Feb 14, 2022. It is now read-only.

Increase timeout of install.IsRunning #6

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

alexmavr
Copy link
Contributor

@alexmavr alexmavr commented Dec 4, 2018

As of kubernetes/kubernetes#66932, included in Kubernetes 1.11.3, the Kubernetes API Server will list unavailable services in its discovery response. This causes the installation to time out after 10 retries, with the following API errors:

2018-12-04T22:46:35.687398778Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server could not find the requested resource (get stacks.compose.docker.com)","time":"2018-12-04T22:46:35Z"}
2018-12-04T22:46:36.689666183Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server could not find the requested resource (get stacks.compose.docker.com)","time":"2018-12-04T22:46:36Z"}
2018-12-04T22:46:37.691736596Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server could not find the requested resource (get stacks.compose.docker.com)","time":"2018-12-04T22:46:37Z"}
2018-12-04T22:46:38.693851921Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server could not find the requested resource (get stacks.compose.docker.com)","time":"2018-12-04T22:46:38Z"}
2018-12-04T22:46:39.696159504Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server could not find the requested resource (get stacks.compose.docker.com)","time":"2018-12-04T22:46:39Z"}
2018-12-04T22:46:40.698704843Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server is currently unable to handle the request (get stacks.compose.docker.com)","time":"2018-12-04T22:46:40Z"}
2018-12-04T22:46:41.701443251Z {"level":"debug","msg":"unable to list composev1beta2 stack: the server is currently unable to handle the request (get stacks.compose.docker.com)","time":"2018-12-04T22:46:41Z"}
2018-12-04T22:46:42.711996071Z {"level":"debug","msg":"unable to list composev1beta1 stack: the server is currently unable to handle the request (get stacks.compose.docker.com)","time":"2018-12-04T22:46:42Z"}
2018-12-04T22:46:43.718401701Z {"level":"debug","msg":"unable to list composev1beta1 stack: the server is currently unable to handle the request (get stacks.compose.docker.com)","time":"2018-12-04T22:46:43Z"}
2018-12-04T22:46:44.725650018Z {"level":"debug","msg":"unable to list composev1beta1 stack: the server is currently unable to handle the request (get stacks.compose.docker.com)","time":"2018-12-04T22:46:44Z"}

This PR parameterizes and increases the number of retries to 60, which should reduce flaky behavior of the installer.

Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alexmavr!

@simonferquel
Copy link
Contributor

In a followup, we'll make sure we expose a parameter for that. But as we are quite in a rush let us merge as is

@simonferquel simonferquel merged commit 727e754 into docker:master Dec 5, 2018
@alexmavr alexmavr deleted the bump-install-timeout branch December 5, 2018 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants