Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "CREATE_ARCHIVE"; archive .deb/.rpm's artifacts directly #175

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 23, 2020

deb and rpm packages are already compressed, so compressing them again does not save any space.

This patch removes the "CREATE_ARCHIVE" option, and instead just the deb/rpm's itself as artifacts

Before this

Tars are uploaded as artefact in Jenkins:

Screenshot 2021-11-22 at 11 48 17

After this

The individual .deb and .rpm packages are uploaded as artefact:

Screenshot 2021-11-23 at 13 05 24

@thaJeztah
Copy link
Member Author

Need to double check if these archives are used elsewhere

@simonferquel @djs55 do you know if these are used by the Docker Desktop team?

@djs55
Copy link

djs55 commented Apr 27, 2020

Looking at the build scripts I don't think Docker Desktop downloads containerd artefacts directly. We use the linuxkit containerd image and we download dockerd binary as a .tar.gz (which I think includes a containerd version?)

@thaJeztah thaJeztah force-pushed the archive_artifacts branch 2 times, most recently from 3fcc219 to e0391e6 Compare November 22, 2021 10:59
deb and rpm packages are already compressed, so compressing
them again does not save any space.

This patch removes the "CREATE_ARCHIVE" option, and instead
just the deb/rpm's itself as artifacts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Looks like the release pipeline currently uses these tars to stash them in an s3 bucket (and later restores them). Need to figure out if there's a way to do this without having to use the intermediate .tar.gz files (challenge is likely that the tars are used to preserve the path / directory structure).

Comment on lines -67 to -69
if [ -n "${CREATE_ARCHIVE}" ]; then
tar -C /build -cvzf "/archive/${DIST_ID}-${DIST_VERSION}-${ARCH}.tar.gz" "${DIST_ID}/${DIST_VERSION}/${ARCH}"
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self; instead of tarring here, perhaps we can use docker build --output type=tar... (although that doesn't support compressing, but I guess all artefacts are already compressed, so from that perspective, it should be fine)

@thaJeztah thaJeztah marked this pull request as draft March 4, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants