Enable unit tests to work with PHP 8.0 #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
force-pushed
the
feature/php8-compatibility
branch
2 times, most recently
from
6e55ec6
to
74736b9
Compare
greg0ire
reviewed
Oct 21, 2021
driehle
force-pushed
the
feature/php8-compatibility
branch
3 times, most recently
from
545f40d
to
bb543e8
Compare
snapshotpl
reviewed
Oct 22, 2021
snapshotpl
approved these changes
Oct 22, 2021
snapshotpl
reviewed
Oct 22, 2021
driehle
force-pushed
the
feature/php8-compatibility
branch
from
da29003
to
9738406
Compare
snapshotpl
approved these changes
Oct 23, 2021
TomHAnderson
approved these changes
Oct 26, 2021
SenseException
approved these changes
Oct 26, 2021
…manager 3.0 is required
driehle
force-pushed
the
feature/php8-compatibility
branch
from
9738406
to
f817c02
Compare
|
Rebased before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves PHP 8.0 compatibility.
DoctrineModulewas already compatible with PHP 8.0 before, but there were some edge cases with the optional dependencylaminas/laminas-mvc-console, which have not been handled.With this PR, explicit checks for the presence of
laminas/laminas-mvc-consolehave been added and errors are reported usingtrigger_error(), when non-installed components are being used.Further, this PR removed the method
\DoctrineModule\Module::getConsoleUsage()when PHP 8.0 is used. This method is used bylaminas/laminas-mvc-console, which is not PHP 8.0-compatible. Hence, this method can never have been used when using PHP 8.0. For PHP 7.3 and 7.4 everything will continoue to work as before. We have discussed this issue on Slack in in the comments here and came to the conclusion that we do not consider this a BC break.This PR targets the next minor release, i.e. 4.2.0.
Fixes #740