Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static analysis with Psalm and PhpStan #744

Merged
merged 10 commits into from
Oct 27, 2021

Conversation

driehle
Copy link
Member

@driehle driehle commented Oct 27, 2021

This PR integrates Psalm and PhpStan. There were some really weird errors of Psalm, where a ParseError occured. The message was as follows:

ERROR: ParseError - src/Module.php:40:17 - Problem loading method: 
    $storage should not be null for DoctrineModule\GetConsoleUsage::getconsoleusage (see https://psalm.dev/173)

I think this is rather a bug in Psalm, might be related to vimeo/psalm#4899. Anyways, I have suppressed that error by using a baseline.

@driehle driehle self-assigned this Oct 27, 2021
@driehle driehle added this to the 4.2.0 milestone Oct 27, 2021
@driehle driehle marked this pull request as ready for review October 27, 2021 13:49
@driehle driehle changed the title [wip] Added static analysis with Psalm and PhpStan Added static analysis with Psalm and PhpStan Oct 27, 2021
@driehle driehle merged commit ee67aab into doctrine:4.2.x Oct 27, 2021
@driehle driehle deleted the feature/static-analysis branch October 27, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants