Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop container-interop/container-interop #792

Merged
merged 2 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"homepage": "http://www.doctrine-project.org/",
"require": {
"php": "^7.4 || ~8.0.0 || ~8.1.0",
"container-interop/container-interop": "^1.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psr/container should become a dependency here, since we still reference it in src/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, added

"doctrine/annotations": "^1.13.2",
"doctrine/cache": "^1.12.1",
"doctrine/collections": "^1.6.8",
Expand All @@ -55,6 +54,7 @@
"laminas/laminas-servicemanager": "^3.10.0",
"laminas/laminas-stdlib": "^3.7.1",
"laminas/laminas-validator": "^2.16.0",
"psr/container": "^1.1.2",
"symfony/console": "^5.4.3 || ^6.0.3"
},
"require-dev": {
Expand Down
2 changes: 1 addition & 1 deletion docs/en/authentication.rst
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ factories as in the example below:
<?php
namespace Application\Factory\Controller;

use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;

class ApplicationControllerFactory implements FactoryInterface
Expand Down
4 changes: 4 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ parameters:
paths:
- src
- tests
ignoreErrors:
-
message: '#internal(G|S)etItem\(\) has parameter \$(casToken|value) with no type specified#'
path: src/Cache/DoctrineCacheStorage.php
Ocramius marked this conversation as resolved.
Show resolved Hide resolved
includes:
- vendor/phpstan/phpstan-phpunit/extension.neon
- vendor/phpstan/phpstan-phpunit/rules.neon
Expand Down
2 changes: 1 addition & 1 deletion src/Service/AbstractFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace DoctrineModule\Service;

use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;
use Laminas\Stdlib\AbstractOptions;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function sprintf;
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Authentication/AdapterFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use DoctrineModule\Authentication\Adapter\ObjectRepository;
use DoctrineModule\Options\Authentication;
use DoctrineModule\Service\AbstractFactory;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function get_class;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

use BadMethodCallException;
use DoctrineModule\Service\AbstractFactory;
use Interop\Container\ContainerInterface;
use Laminas\Authentication\AuthenticationService;
use Psr\Container\ContainerInterface;

/**
* Factory to create authentication service object.
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Authentication/StorageFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use DoctrineModule\Authentication\Storage\ObjectRepository;
use DoctrineModule\Options\Authentication;
use DoctrineModule\Service\AbstractFactory;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function get_class;
Expand Down
2 changes: 1 addition & 1 deletion src/Service/CacheFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Doctrine\Common\Cache\CacheProvider;
use DoctrineModule\Cache\LaminasStorageCache;
use DoctrineModule\Options\Cache as CacheOptions;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function get_class;
Expand Down
2 changes: 1 addition & 1 deletion src/Service/CliFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace DoctrineModule\Service;

use Interop\Container\ContainerInterface;
use Laminas\EventManager\EventManagerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;
use Psr\Container\ContainerInterface;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Helper\HelperSet;

Expand Down
2 changes: 1 addition & 1 deletion src/Service/DriverFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
use Doctrine\Persistence\Mapping\Driver\MappingDriver;
use Doctrine\Persistence\Mapping\Driver\MappingDriverChain;
use DoctrineModule\Options\Driver;
use Interop\Container\ContainerInterface;
use InvalidArgumentException;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function class_exists;
Expand Down
2 changes: 1 addition & 1 deletion src/Service/EventManagerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
use Doctrine\Common\EventManager;
use Doctrine\Common\EventSubscriber;
use DoctrineModule\Options\EventManager as EventManagerOptions;
use Interop\Container\ContainerInterface;
use InvalidArgumentException;
use Psr\Container\ContainerInterface;
use RuntimeException;

use function class_exists;
Expand Down
2 changes: 1 addition & 1 deletion src/ServiceFactory/AbstractDoctrineServiceFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

namespace DoctrineModule\ServiceFactory;

use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Exception\ServiceNotFoundException;
use Laminas\ServiceManager\Factory\AbstractFactoryInterface;
use Psr\Container\ContainerInterface;

use function preg_match;

Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Service/AbstractValidatorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
use Doctrine\Persistence\ObjectManager;
use Doctrine\Persistence\ObjectRepository;
use DoctrineModule\Validator\Service\Exception\ServiceCreationException;
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\Factory\FactoryInterface;
use Laminas\Stdlib\ArrayUtils;
use Psr\Container\ContainerInterface;

use function class_exists;
use function is_string;
Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Service/NoObjectExistsFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace DoctrineModule\Validator\Service;

use DoctrineModule\Validator\NoObjectExists;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;

final class NoObjectExistsFactory extends AbstractValidatorFactory
{
Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Service/ObjectExistsFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace DoctrineModule\Validator\Service;

use DoctrineModule\Validator\ObjectExists;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;

final class ObjectExistsFactory extends AbstractValidatorFactory
{
Expand Down
2 changes: 1 addition & 1 deletion src/Validator/Service/UniqueObjectFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace DoctrineModule\Validator\Service;

use DoctrineModule\Validator\UniqueObject;
use Interop\Container\ContainerInterface;
use Psr\Container\ContainerInterface;

final class UniqueObjectFactory extends AbstractValidatorFactory
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Validator/Service/NoObjectExistsFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
use DoctrineModule\Validator\Service\Exception\ServiceCreationException;
use DoctrineModule\Validator\Service\NoObjectExistsFactory;
use DoctrineModuleTest\Validator\TestAsset\DummyClass;
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\ServiceLocatorInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\Container\ContainerInterface;

/**
* Generated by PHPUnit_SkeletonGenerator on 2017-09-04 at 11:12:27.
Expand Down
2 changes: 1 addition & 1 deletion tests/Validator/Service/ObjectExistsFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
use DoctrineModule\Validator\ObjectExists;
use DoctrineModule\Validator\Service\ObjectExistsFactory;
use DoctrineModuleTest\Validator\TestAsset\DummyClass;
use Interop\Container\ContainerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\Container\ContainerInterface;

/**
* Generated by PHPUnit_SkeletonGenerator on 2017-09-04 at 11:55:36.
Expand Down
2 changes: 1 addition & 1 deletion tests/Validator/Service/UniqueObjectFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
use DoctrineModule\Validator\Service\UniqueObjectFactory;
use DoctrineModule\Validator\UniqueObject;
use DoctrineModuleTest\Validator\TestAsset\DummyClass;
use Interop\Container\ContainerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Psr\Container\ContainerInterface;

/**
* Generated by PHPUnit_SkeletonGenerator on 2017-09-04 at 11:57:37.
Expand Down