Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PSR12.Properties.ConstantVisibility in favor of slevomat #203

Open
wants to merge 1 commit into
base: 8.2.x
Choose a base branch
from

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Jun 19, 2020

Isn't this already checked by slevomat?

Does the one cover cases that the other does not? Then if yes.. shouldn't the PSR12.Properties.ConstantVisibility be turned to an error.. because currently it is a warning

@gmponos gmponos requested a review from a team as a code owner June 19, 2020 09:09
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits of using Slevomat's rule instead of PHPCS'?

Does it check more stuff or stricter?

I always like to think as well: slevomat/coding-standard is an extension for PHPCS. The less we depend on it, better! We might remove it one day as PHPCS is going to cover everything.

@gmponos
Copy link
Contributor Author

gmponos commented Jun 23, 2020

What are the benefits of using Slevomat's rule instead of PHPCS'?

  1. phpcs is a warning. Can be easily converted to error.. no problem here.
  2. there is no autofix.. The policy of phpcs maintainer -which I agree with- is a little bit defensive against these kind of autofix

@gmponos
Copy link
Contributor Author

gmponos commented Jun 23, 2020

If you want my opinion I would prefer using the phpcs one instead of slevomat even without the autofix.

@greg0ire greg0ire changed the base branch from master to 8.2.x October 25, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants