-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more precise return type for count method #355
Conversation
If it doesn't break what #353 solves, that looks good indeed. |
Yeah, I was wondering if I needed the Because the LazyCollection use inherit |
I just tried in my project @greg0ire and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for triple checking, Vincent 🙏
Technically not a bugfix, but it's OK to target 2.1 IMO because the things it's improving is not released yet. |
Countable is supposed to return
(vimeo/psalm#8861)
So I would say it's better to rely on inherit doc rather than overriding the return tag ?
@greg0ire