Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Psalm 5 #370

Merged
merged 1 commit into from
May 8, 2023
Merged

Upgrade to Psalm 5 #370

merged 1 commit into from
May 8, 2023

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 8, 2023

No description provided.

<errorLevel type="suppress">
<file name="src/AbstractLazyCollection.php"/>
</errorLevel>
</MixedReturnStatement>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused by

ERROR: MixedInferredReturnType - src/AbstractLazyCollection.php:277:21 - Could not verify return type 'TInitial|TReturn|null' for Doctrine\Common\Collections\AbstractLazyCollection::reduce (see https://psalm.dev/047)
    public function reduce(Closure $func, mixed $initial = null)


ERROR: MixedReturnStatement - src/AbstractLazyCollection.php:281:16 - Could not infer a return type (see https://psalm.dev/138)
        return $this->collection->reduce($func, $initial);

This seems to complex for Psalm.

@derrabus derrabus added this to the 2.1.3 milestone May 8, 2023
@derrabus derrabus merged commit a72b781 into doctrine:2.1.x May 8, 2023
@greg0ire greg0ire deleted the psalm-5 branch May 9, 2023 11:14
derrabus added a commit that referenced this pull request Jul 24, 2023
* 2.1.x:
  Added the documentation.yml to the workflows
  Applying latest coding standards
  Remove override of template type: causing psalm errors
  Upgrade to Psalm 5 (#370)
derrabus added a commit that referenced this pull request Jul 24, 2023
* 2.1.x:
  Added the documentation.yml to the workflows
  Applying latest coding standards
  Remove override of template type: causing psalm errors
  Upgrade to Psalm 5 (#370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants