Add MariaDb1010Platform for fetchTableOptionsByTable #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jun 9, 2024
grooverdan
force-pushed
the
fetchTableOptions_split.x
branch
from
229ef63
to
def1b4c
Compare
The diverging MariaDB-10.10.1+ implementation of retrieving table options split the implementation so that its now in the AbstractMySQLPlatform and the MariaDB specific implementation in MariaDBPlatform. Fixes #6361.
derrabus
force-pushed
the
fetchTableOptions_split.x
branch
from
def1b4c
to
efb1914
Compare
|
Thank you. I've simplified the signature of |
derrabus
approved these changes
Jun 18, 2024
|
We get a lot of false positives from CodeCov these days unfortunately. |
|
Thanks for the merge. Appoligies for missing the signature cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested: #6425 (comment)
The diverging MariaDB-10.10.1+ implementation of retrieving table options split the implementation so that its now in the AbstractMySQLPlatform and the MariaDB specific implementation in MariaDBPlatform.
On CI - I don't follow the 'useless $sql' error.