Fix update/delete aliases in documentation #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jul 16, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 23, 2024
* 4.0.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Fix update/delete aliases in documentation (doctrine#6470) Complete sentence Docs: update custom platform example to use middlewares (doctrine#6460) ci: nightly - php-8.1 only + workflow_dispatch ci: nightly - php-8.1 min version (doctrine#6457) mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 23, 2024
* 4.1.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) Add SmallFloat type (doctrine#6471) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Fix update/delete aliases in documentation (doctrine#6470) Complete sentence Docs: update custom platform example to use middlewares (doctrine#6460) ci: nightly - php-8.1 only + workflow_dispatch ci: nightly - php-8.1 min version (doctrine#6457) mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6394 the documentation was partially updated to remove aliases for the documentation for the update method, as the separate parameter for it was removed in the upgrade from 3.x to 4.x.
Inline aliasing is still possible, and I suspect this was the reason the extra parameter was removed. (
->update('users alias1', 'alias2'))?This PR readds the alias to the documentation for the occurences in the linked PR, and also updates the other occurences in docblocks + the online documentation.