Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: old php versions compat cleanup #23

Merged
merged 26 commits into from
Jul 22, 2017
Merged

Cleanup: old php versions compat cleanup #23

merged 26 commits into from
Jul 22, 2017

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Dec 3, 2015

This PR removes the ugly hacks required for some specific older PHP versions, replacing them with the assumptions that PHP 5.6.0+ is going to be used.

Note: this is supposed to happen on master, which is going to be 1.1.0.
1.0.x is still going to be supported.

@Ocramius Ocramius self-assigned this Dec 3, 2015
@Ocramius Ocramius added this to the 1.1.0 milestone Dec 3, 2015
@Ocramius
Copy link
Member Author

Ocramius commented Dec 3, 2015

Note: tests can only succeed once this is in master, as otherwise cyclic dependencies prevent installation.

@Ocramius
Removing code that deals with PHP <= 5.6
1d505fd
@Ocramius
isCloneable always exists
2a27cfa
@Ocramius
Method simplification
d02ccc1
@Ocramius
Reducing number of method calls in Instantiator
c452d79
@Ocramius
Requiring at least PHP 5.6 when dealing with the next version of this…
737557a 
… library
@Ocramius
Testing should happen on PHP 7 as well
1b3f781
@Ocramius
Removing checks for PHP version 5.3.3 and other affected weirdos
b5f1d8f
@Ocramius
Removing incorrect bash syntax
759fa3b
@Ocramius
Master is now 1.1.x-dev
989a6e9
@Ocramius
Removing clutter from tests (php version checks)
c1dc0f2
@Ocramius
::class over string constants
508a3f9
@Ocramius
::class over string constants
f9a5d29
@Ocramius
::class over string constants
90bea39
@Ocramius
Short array syntax
e5af279
@Ocramius
Correcting documentation usage - should reference class names via `::…
dbad3d2 
…class`
@Ocramius
#23 dropped PHP versions previous to 7.1
d398260
@Ocramius
#23 generic cleanups via additions of PHP 7 hints
916a37f
@Ocramius
#23 adding return and parameter hints to existing API
8e36d83
@Ocramius
#23 adding return hints wherever possible
874097c
@Ocramius Ocramius force-pushed the cleanup/old-php-versions-compat-cleanup branch from 9d29254 to 874097c Compare July 22, 2017 11:40
@Ocramius
Copy link
Member Author

This can't pass on master due to conflicting requirements with PHPUnit, which in turn requires the library itself.

@Ocramius Ocramius merged commit 8f4b1a1 into master Jul 22, 2017
@Ocramius Ocramius deleted the cleanup/old-php-versions-compat-cleanup branch July 22, 2017 11:55
Ocramius added a commit that referenced this pull request Jul 22, 2017
@Ocramius
#23 bumping master branch alias - now 1.2.x-dev
185b886
@jeffwidman jeffwidman mentioned this pull request Jan 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Ocramius