Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPstan to 0.12 #77

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Update PHPstan to 0.12 #77

merged 3 commits into from
Nov 9, 2020

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 8, 2020

Upgrading required to add some generics.

@greg0ire
Copy link
Member

greg0ire commented Nov 9, 2020

This does not look like a bugfix, arguably with the generics it's more like a feature. master is aliased to 1.4.x, I think I will just rename master if BC-breaks were not mistakenly merged in it.

@greg0ire greg0ire changed the base branch from 1.3.x to 1.4.x November 9, 2020 18:28
@greg0ire greg0ire merged commit 4307506 into doctrine:1.4.x Nov 9, 2020
@greg0ire
Copy link
Member

greg0ire commented Nov 9, 2020

Thanks @franmomu !

@greg0ire greg0ire added this to the 1.4.0 milestone Nov 9, 2020
@greg0ire greg0ire mentioned this pull request Nov 10, 2020
Merged
@franmomu franmomu deleted the feature/bump_phpstan branch November 10, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @greg0ire