Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent externals sub properties in the README #205

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Conversation

JamesLMilner
Copy link
Contributor

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

At the moment these properties are at the same level as the externals property, when they should be nested under dependencies

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   52.88%   52.88%           
=======================================
  Files          10       10           
  Lines         571      571           
  Branches      139      139           
=======================================
  Hits          302      302           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e979b98...61b45e4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants