Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memory watch and implement reload with normal watch #224

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 14, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Removes "memory" watch which loaded bundles in memory and was not compatible with build time render. Changes the "file" watch to use the webpack-hot-middleware and support automatically reloading of the browser when used with --serve

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #224 into master will decrease coverage by 1.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #224      +/-   ##
=========================================
- Coverage   53.64%   52.6%   -1.04%     
=========================================
  Files          10      10              
  Lines         604     595       -9     
  Branches      147     144       -3     
=========================================
- Hits          324     313      -11     
- Misses        280     282       +2
Impacted Files Coverage Δ
src/dist.config.ts 33.33% <0%> (ø) ⬆️
src/dev.config.ts 21.15% <0%> (ø) ⬆️
src/main.ts 90.58% <90.9%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fc06d...1555ce7. Read the comment docs.

Copy link
Contributor

@mwistrand mwistrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agubler agubler merged commit 96e9fd9 into dojo:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants