Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit the html even if it was not changed #230

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 11, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Do not use cache with the html-webpack-plugin as we need the index.html to be emitted even if there are no changes.

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #230   +/-   ##
======================================
  Coverage    52.5%   52.5%           
======================================
  Files          10      10           
  Lines         600     600           
  Branches      146     146           
======================================
  Hits          315     315           
  Misses        285     285
Impacted Files Coverage Δ
src/dev.config.ts 21.15% <ø> (ø) ⬆️
src/dist.config.ts 32.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add134e...0acc854. Read the comment docs.

@agubler agubler merged commit 6076313 into dojo:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants