Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set public path to match the base config options for mini css loader #316

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Sep 11, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Sets the publicPath of the mini CSS loader to the dojorc base option, defaulting to /. This ensure that assets can be loaded from code split CSS.

Resolves #315

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #316 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   47.97%   47.83%   -0.14%     
==========================================
  Files          10       10              
  Lines         690      692       +2     
  Branches      195      196       +1     
==========================================
  Hits          331      331              
- Misses        359      361       +2
Impacted Files Coverage Δ
src/base.config.ts 18.64% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6001e...41ed724. Read the comment docs.

@agubler agubler merged commit 9bad4bc into dojo:master Sep 12, 2019
agubler added a commit to agubler/cli-build-app that referenced this pull request Sep 18, 2019
@agubler
Copy link
Member Author

agubler commented Sep 19, 2019

This has caused issues when serving from a directory, investigating alternative fixes. Otherwise will possibly need to revert.

agubler added a commit to agubler/cli-build-app that referenced this pull request Sep 19, 2019
agubler added a commit that referenced this pull request Sep 20, 2019
@maier49 maier49 mentioned this pull request May 29, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to load images from code split CSS
2 participants