Fix layout and hashing #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettierDescription:
My previous attempt to fix these was to put the image in the same structure as the bundles. That worked, except for with a dynamic
__webpack_public_path__, since the paths inurl()s in CSS files were still generated at build time. They can't be absolute since the final path may not be from the root, and the relative path is always wrong since it has the path to the css file tacked on by the browser. Putting the css and js bundles at the root (using the naming conventionpath-to-filename.ext) works in all these scenarios since the paths are just relative to the root of the project.Resolves #314, #315