Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mobile html #14

Closed
dopecodez opened this issue Mar 31, 2021 · 0 comments · Fixed by #17
Closed

Implement mobile html #14

dopecodez opened this issue Mar 31, 2021 · 0 comments · Fixed by #17
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dopecodez
Copy link
Owner

There are a lot of new REST APIs for wikipedia present in the REST API docs.

We'll look through them one by one and implement the same. Any one who wants to pick up on any other REST API should ideally open a new issue.

The REST API has a /page/mobile-html/{title} endpoint which which provides mobile friendly html.

Implementation for this should follow the summary or related method flow. Remember to write unit tests for all possible scenarios in your new functions, and try to use types as far as possible.

I'll be happy to help anyone who wants to pick this up.
@dopecodez dopecodez added enhancement New feature or request help wanted Extra attention is needed labels Mar 31, 2021
friendofdog added a commit to friendofdog/Wikipedia that referenced this issue Apr 19, 2021
@friendofdog
makeRestRequest parses text and JSON responses
ba806cc 
Had previously been calling .json() on all responses, even if they
were strings. Can now handle JSON and string responses.

resolving dopecodez#14
friendofdog added a commit to friendofdog/Wikipedia that referenced this issue Apr 19, 2021
@friendofdog
Add mobileHtml(), get mobile-optimised HTML
f4a156d 
Returns HTML for mobile for a given page.

resolving dopecodez#14
@friendofdog friendofdog mentioned this issue Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement method for mobile-html friendofdog/Wikipedia
1 participant
@dopecodez