Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws IP_NOT_VALID error on short subdomains #33

Closed
foxxyz opened this issue Jul 7, 2021 · 1 comment · Fixed by #34
Closed

Throws IP_NOT_VALID error on short subdomains #33

foxxyz opened this issue Jul 7, 2021 · 1 comment · Fixed by #34
Labels
bug Something isn't working

Comments

@foxxyz
Copy link
Contributor

foxxyz commented Jul 7, 2021

When using short subdomains (E.G. i.test.example.com), calling ping will incorrectly throw an error with Given IP address is not valid.

Likely due to a too-strict regex in validateIp.

Example:

try {
    await ping('i.test.example.com') // will throw "ipError: Given IP address is not valid"
}
catch(err) {
    console.error(err)
}
foxxyz added a commit to foxxyz/pingman that referenced this issue Jul 8, 2021
@dopecodez dopecodez added the bug Something isn't working label Jul 8, 2021
dopecodez pushed a commit that referenced this issue Jul 9, 2021
@dopecodez
Copy link
Owner

Released on https://github.com/dopecodez/pingman/releases/tag/v1.1.3 🎉 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants