Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolvers] Add avoidCheckingAbstractTypesRecursively option to support nested defaultMappers #10141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eddeee888
Copy link
Collaborator

Description

Related #10084

In #10014, we fixed an issue where nested abstract types were not getting the correct types. This, however, caused existing usage of nested defaultMapper to be in an infinite loop.

This PR adds avoidCheckingAbstractTypesRecursively option to preserve the existing defaultMapper behaviours by setting to true

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit test

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 77c20ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-codegen/visitor-plugin-common Minor
@graphql-codegen/typescript-resolvers Minor
@graphql-codegen/typescript-document-nodes Patch
@graphql-codegen/gql-tag-operations Patch
@graphql-codegen/typescript-operations Patch
@graphql-codegen/typed-document-node Patch
@graphql-codegen/typescript Patch
@graphql-codegen/graphql-modules-preset Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 5.0.3-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 5.4.0-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 4.0.10-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 4.0.10-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.3.0-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.3.0-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 5.0.10-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.1.0-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 4.4.0-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 4.0.10-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎
@graphql-codegen/testing 3.0.4-alpha-20240916113955-77c20ed2bcdb729396448b8cb0a3aead8606480a npm ↗︎ unpkg ↗︎

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://6fa83017.graphql-code-generator.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant