Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mark rules #743

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Update mark rules #743

merged 10 commits into from
Sep 13, 2024

Conversation

brage-andreas
Copy link
Member

This PR updates mark rules in accordance to https://old.online.ntnu.no/wiki/komiteer/nyeprikkregler/

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
onlineweb-frontend ✅ Ready (Inspect) Visit Preview Sep 13, 2024 3:09pm

Copy link
Member

@henrikhorluck henrikhorluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi har et API for dette fra OW4: https://old.online.ntnu.no/api/v1/marks/rule-sets/

Kan vi bruke det i stedet?

Da får du også min approval til å fjerne tilsvarende i ow4 og redirecte til owf

Copy link
Member

@henrikhorluck henrikhorluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kode-messig så er sånne "helpere" som inFuture ikke nødvendigvis faktisk nyttig

Det er masse kode i OW4 som er nesten uforståelig fordi alt går via one-time-use helpers som gjør det utrolig tungvindt å skjønne hva som faktisk skjer og hvilke data og slik som hentes ut https://github.com/dotkom/onlineweb4/blob/main/apps/payment/mommy.py

Copy link

sonarcloud bot commented Sep 13, 2024

@brage-andreas brage-andreas merged commit 2c59ce3 into master Sep 13, 2024
4 of 6 checks passed
@brage-andreas brage-andreas deleted the update-mark-rules branch September 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants