Add warning support (#2572)

dotnet · Jun 1, 2024 · 6a7244d · 6a7244d
1 parent 063d2f0
commit 6a7244d
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 4 deletions.
diff --git a/src/BenchmarkDotNet.TestAdapter/VSTestLogger.cs b/src/BenchmarkDotNet.TestAdapter/VSTestLogger.cs
@@ -33,8 +33,12 @@ public void Write(LogKind logKind, string text)
 
             // Assume that if the log kind is an error, that the whole line is treated as an error
             // The level will be reset to Informational when WriteLine() is called.
-            if (logKind == LogKind.Error)
-                currentLevel = TestMessageLevel.Error;
+            currentLevel = logKind switch
+            {
+                LogKind.Error => TestMessageLevel.Error,
+                LogKind.Warning => TestMessageLevel.Warning,
+                _ => currentLevel
+            };
         }
 
         public void WriteLine()

diff --git a/src/BenchmarkDotNet/Analysers/ConclusionHelper.cs b/src/BenchmarkDotNet/Analysers/ConclusionHelper.cs
@@ -10,7 +10,7 @@ public static class ConclusionHelper
         public static void Print(ILogger logger, IEnumerable<Conclusion> conclusions)
         {
             PrintFiltered(conclusions, ConclusionKind.Error, "Errors", logger.WriteLineError);
-            PrintFiltered(conclusions, ConclusionKind.Warning, "Warnings", logger.WriteLineError);
+            PrintFiltered(conclusions, ConclusionKind.Warning, "Warnings", logger.WriteLineWarning);
             PrintFiltered(conclusions, ConclusionKind.Hint, "Hints", logger.WriteLineHint);
         }
 

diff --git a/src/BenchmarkDotNet/Loggers/ConsoleLogger.cs b/src/BenchmarkDotNet/Loggers/ConsoleLogger.cs
@@ -79,6 +79,7 @@ private static Dictionary<LogKind, ConsoleColor> CreateColorfulScheme() =>
                 { LogKind.Statistic, ConsoleColor.Cyan },
                 { LogKind.Info, ConsoleColor.DarkYellow },
                 { LogKind.Error, ConsoleColor.Red },
+                { LogKind.Warning, ConsoleColor.Yellow },
                 { LogKind.Hint, ConsoleColor.DarkCyan }
             };
 

diff --git a/src/BenchmarkDotNet/Loggers/LinqPadLogger.cs b/src/BenchmarkDotNet/Loggers/LinqPadLogger.cs
@@ -82,6 +82,7 @@ private static IReadOnlyDictionary<LogKind, string> CreateDarkScheme() =>
                 { LogKind.Statistic, "#00FFFF" },
                 { LogKind.Info, "#808000" },
                 { LogKind.Error, "#FF0000" },
+                { LogKind.Warning, "#FFFF00" },
                 { LogKind.Hint, "#008080" }
             };
 
@@ -95,6 +96,7 @@ private static IReadOnlyDictionary<LogKind, string> CreateLightScheme() =>
                 { LogKind.Statistic, "#008080" },
                 { LogKind.Info, "#808000" },
                 { LogKind.Error, "#FF0000" },
+                { LogKind.Warning, "#FFFF00" },
                 { LogKind.Hint, "#008080" }
             };
     }

diff --git a/src/BenchmarkDotNet/Loggers/LogKind.cs b/src/BenchmarkDotNet/Loggers/LogKind.cs
@@ -2,6 +2,6 @@
 {
     public enum LogKind
     {
-        Default, Help, Header, Result, Statistic, Info, Error, Hint
+        Default, Help, Header, Result, Statistic, Info, Error, Hint, Warning
     }
 }
diff --git a/src/BenchmarkDotNet/Loggers/LoggerExtensions.cs b/src/BenchmarkDotNet/Loggers/LoggerExtensions.cs
@@ -18,6 +18,8 @@ public static class LoggerExtensions
 
         public static void WriteLineError(this ILogger logger, string text) => logger.WriteLine(LogKind.Error, text);
 
+        public static void WriteLineWarning(this ILogger logger, string text) => logger.WriteLine(LogKind.Warning, text);
+
         public static void WriteLineHint(this ILogger logger, string text) => logger.WriteLine(LogKind.Hint, text);
 
         public static void Write(this ILogger logger, string text) => logger.Write(LogKind.Default, text);
@@ -36,6 +38,8 @@ public static class LoggerExtensions
 
         public static void WriteError(this ILogger logger, string text) => logger.Write(LogKind.Error, text);
 
+        public static void WriteWarning(this ILogger logger, string text) => logger.Write(LogKind.Warning, text);
+
         [PublicAPI]
         public static void WriteHint(this ILogger logger, string text) => logger.Write(LogKind.Hint, text);
     }