Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide metric columns if value could not be calculated #2633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hide metric columns if value could not be calculated #2633

wants to merge 1 commit into from

Conversation

clegoz
Copy link

@clegoz clegoz commented Sep 8, 2024

Fixes #2629

@clegoz
Copy link
Author

clegoz commented Sep 8, 2024

@dotnet-policy-service agree

@timcassell
Copy link
Collaborator

My concern with this change is users adding the diagnoser and being surprised by no column showing. Perhaps the auto-hide feature should be behind a configuration on the diagnoser itself. See https://github.com/dotnet/BenchmarkDotNet/blob/ca5dfdf106affb0922f5b8002a67272a27d3fd03/src/BenchmarkDotNet/Diagnosers/MemoryDiagnoserConfig.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ability to automatically hide metric columns if value is not set
2 participants
@clegoz @timcassell