Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThenInclude required? #2873

Closed
ygoe opened this issue Nov 15, 2020 · 1 comment · Fixed by #2878
Closed

ThenInclude required? #2873

ygoe opened this issue Nov 15, 2020 · 1 comment · Fixed by #2878
Assignees
@maumar
Labels
area-query-related-data closed-fixed
Milestone
5.0.0

Comments

@ygoe
Copy link

ygoe commented Nov 15, 2020

Is the use of ThenInclude required? I can also just call .Include(e => e.Related1.SubRelated2) to do it all in one step. What's the difference?

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@ajcvickers
Copy link
Member

Note for triage: we should show examples of dotting through for reference Includes.

@ygoe In general, ThenInclude is needed for collections. However, it helps consistency to show the same pattern for both references and collections.

@ajcvickers ajcvickers added this to the Backlog milestone Nov 16, 2020
maumar added a commit that referenced this issue Nov 16, 2020
@maumar
Fix to #2873 - ThenInclude required?
0d42eb1 
Added example for using single Include/ThenInclude method call to load multiple navigations.
@maumar maumar modified the milestones: Backlog, 5.0.0 Nov 16, 2020
@maumar maumar mentioned this issue Nov 16, 2020
Merged
@maumar maumar closed this as completed in 7c989a2 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query-related-data closed-fixed
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix to #2873 - ThenInclude required? dotnet/EntityFramework.Docs
3 participants
@ygoe @ajcvickers @maumar