Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make breadcrumbs consistent with .NET and ASP.NET docs #2159

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Make breadcrumbs consistent with .NET and ASP.NET docs #2159

merged 2 commits into from
Mar 4, 2020

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Mar 3, 2020 •
edited
Loading

Fixes #2131

Internal review page

This PR also updates the master ToC by:

  • Removing gerunds, where it makes sense
  • Convert titles to sentence case

ajcvickers
ajcvickers approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @scottaddie :-)

@scottaddie
Copy link
Member Author

@smitpatel @ajcvickers I have a bit more testing to do, but so far everything looks good. Hold off on merging for now.

@scottaddie scottaddie changed the title Make breadcrumbs consistent with .NET docs Make breadcrumbs consistent with .NET and ASP.NET docs Mar 3, 2020
@scottaddie scottaddie marked this pull request as ready for review March 3, 2020 20:25
@scottaddie
Copy link
Member Author

@smitpatel @ajcvickers Ready for one last review. You can use the following link to preview the changes:

https://review.docs.microsoft.com/ef/core/?branch=pr-en-us-2159

smitpatel
smitpatel approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@smitpatel
Copy link
Member

A related weird thing. @ajcvickers can define behavior

https://review.docs.microsoft.com/en-us/ef/core/miscellaneous/testing/sqlite?branch=pr-en-us-2159
When clicking on fundamentals in breadcrumbs, it takes to connection strings page since there is no overview page for fundamentals. Should we make this experience somewhat better? How?

@scottaddie
Copy link
Member Author

@smitpatel The preferred approach is to create an Overview page within the Fundamentals node. That doesn't exist, so I have it link to the Connection Strings doc instead.

@ajcvickers ajcvickers mentioned this pull request Mar 3, 2020
Open
@ajcvickers
Copy link
Member

I think it's fine for now. But we should create an Overview page at some point. Filed #2160

@scottaddie scottaddie merged commit 0a9151c into master Mar 4, 2020
@scottaddie scottaddie deleted the scottaddie/fix-breadcrumb-links branch March 4, 2020 15:57
@scottaddie scottaddie mentioned this pull request Mar 5, 2020
Merged
@ajcvickers ajcvickers mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumb path are not links
3 participants
@scottaddie @smitpatel @ajcvickers