Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for value comparers #2192

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Documentation for value comparers #2192

merged 1 commit into from
Mar 20, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #1986

@ajcvickers ajcvickers force-pushed the ButSomehowTheVitalConnectionIsMade0317 branch 3 times, most recently from 947ea10 to 77cec99 Compare March 18, 2020 21:41
@ajcvickers ajcvickers changed the title WIP: Documentation for value comparers Documentation for value comparers Mar 18, 2020
@ajcvickers ajcvickers requested a review from a team March 18, 2020 21:48
@AndriySvyryd AndriySvyryd mentioned this pull request Mar 19, 2020
Closed
@ajcvickers ajcvickers force-pushed the ButSomehowTheVitalConnectionIsMade0317 branch 3 times, most recently from b402547 to 33b0518 Compare March 19, 2020 17:41
@ajcvickers
Copy link
Member Author

@smitpatel Can I merge this?

@ajcvickers
Copy link
Member Author

@smitpatel Can I merge this?

@smitpatel
Copy link
Member

What is acrolinx score?

@ajcvickers ajcvickers force-pushed the ButSomehowTheVitalConnectionIsMade0317 branch from 33b0518 to 2c40e54 Compare March 19, 2020 22:43
@ajcvickers
Copy link
Member Author

What is acrolinx score? - I don't care. I want to deliver value for customers, not get a high score on some set of rules.

@smitpatel Can I merge this?

@smitpatel
Copy link
Member

I don't care about high score either. But there was typo. At least it catches those obvious cases. It is same as saying to deliver feature we don't care about code quality.
Someone else can sign off, I am not.

@smitpatel smitpatel requested a review from a team March 19, 2020 22:59
@ajcvickers
Copy link
Member Author

Where is the typo?

@ajcvickers ajcvickers force-pushed the ButSomehowTheVitalConnectionIsMade0317 branch from 2c40e54 to fc76581 Compare March 20, 2020 21:07
@ajcvickers ajcvickers merged commit 2864d29 into master Mar 20, 2020
@smitpatel smitpatel deleted the ButSomehowTheVitalConnectionIsMade0317 branch March 23, 2020 20:02
@ajcvickers ajcvickers mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@smitpatel smitpatel Awaiting requested review from smitpatel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need discussion of Value Comparers
3 participants
@ajcvickers @smitpatel @AndriySvyryd