Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wpf.md #2235

Merged
merged 4 commits into from
Apr 3, 2020
Merged

Update wpf.md #2235

merged 4 commits into from
Apr 3, 2020

Conversation

JeremyLikness
Copy link
Member

Add notice for .NET Framework.

Add notice for .NET Framework.
Fix EF Core link
Second attempt to fix EF Core docs link
>
> This document covers databinding for WPF on the .NET Framework. For WPF on .NET Core, please refer to the [EF Core documentation](~ef/core).
> This document describes databinding for WPF on the .NET Framework. If your app is built with .NET Core, please refer to the [EF Core documentation](~/ef/core).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is right. Is using EF Core (as opposed to EF6 on .NET Core) going to help here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to word this? Our guidance for new .NET Core projects is to use EF Core, right? We can look separately at having a databinding section there, but I'm assuming either new projects (EF6 + .NET Framework) will make sense, OR they may be porting existing EF6 code from .NET Framework to .NET Core in which case this document is irrelevant (because it is a file->new experience).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajcvickers I revised the language to reference #778

@JeremyLikness JeremyLikness self-assigned this Mar 31, 2020
Add issue reference
@JeremyLikness JeremyLikness merged commit e373809 into master Apr 3, 2020
@JeremyLikness JeremyLikness deleted the JeremyLikness-patch-1 branch April 3, 2020 16:01
@smitpatel
Copy link
Member

Next make sure to squash commits and do Squash and merge or Rebase and merge. Avoid creating merge commits when merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants