New EF Hub + toc, docfx and breadcrumb toc updates #2279
Conversation
|
@wadepickett Just want to say I'm really looking forward to reviewing this, but I'm a bit behind because I'm playing catch-up after a few days off. |
smitpatel
force-pushed
the
wade-pickett/ef-hub-4-13-20
branch
from
725843f
to
b03884a
Compare
smitpatel
force-pushed
the
wade-pickett/ef-hub-4-13-20
branch
from
b03884a
to
336d469
Compare
|
@wadepickett - Fixed all build errors. Do you want to continue on this PR to get it merged to master? |
- Fixed API reference title - Removed asp.net + EF quickstart from top.
|
@ smitpatel, many thanks!!! Please hold off on merging to master, first I also need sign-off from Robert Lyon who is watching over all Hub designs to make sure they all work together well across products. I sent him a review request. I did make the fixes you and Arthur requested. |
Fixed link for EF + Razor Pages tutorial
Fixed "Saving Basic" link.
There was a problem hiding this comment.
Looks like all of the changes I was considering have been made. Approved on my end, deferring to @ajcvickers
There was a problem hiding this comment.
This is great! We can tweak things as we evolve the documentation, but I don't see anything I would immediately change. This is way better than we had before! Thanks @wadepickett!
Robert Lyon recommended some edits. I made the following changes: Get Started cards • Changed choose a version at the top to an overview type. It was a bit confusing laving two getting started topics at the top. You might be able to shorten some of the text • Getting Started with Entity Framework Core --> Entity Framework Core (since we have Get Started title and icon with it) • Course - Persist and retrieve relational data with Entity Framework Core --> Persist and retrieve relational data with Entity Framework Core • Choose a version of EF that is right for you --> Choose a version that is right for you • Entity Framework API reference browser --> API reference browser • Previous Entity Framework Versions --> Previous versions Adjusted capping • Create a model • Save data • Supported databases • Command-line reference
|
Robert Lyon also signed off now so I will go ahead and merge. Thanks everyone for the fantastic help. |
* New EF Hub + toc, docfx and breadcrumb toc updates * Fix build errors * Update index.yml - Fixed API reference title - Removed asp.net + EF quickstart from top. * Update index.yml Fixed link for EF + Razor Pages tutorial * Update index.yml Fixed "Saving Basic" link. * Update index.yml Robert Lyon recommended some edits. I made the following changes: Get Started cards • Changed choose a version at the top to an overview type. It was a bit confusing laving two getting started topics at the top. You might be able to shorten some of the text • Getting Started with Entity Framework Core --> Entity Framework Core (since we have Get Started title and icon with it) • Course - Persist and retrieve relational data with Entity Framework Core --> Persist and retrieve relational data with Entity Framework Core • Choose a version of EF that is right for you --> Choose a version that is right for you • Entity Framework API reference browser --> API reference browser • Previous Entity Framework Versions --> Previous versions Adjusted capping • Create a model • Save data • Supported databases • Command-line reference Co-authored-by: Smit Patel <smitpatel@users.noreply.github.com>
Internal Review
Fixes #2341