Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to samples to make them build, plus Github Action to prevent breaks #2327

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Fixes to samples to make them build, plus Github Action to prevent breaks #2327

merged 2 commits into from
Apr 27, 2020

Conversation

roji
Copy link
Member

@roji roji commented Apr 27, 2020

  • Fix solution project reference
  • Target netcoreapp3.1 instead of netcoreapp3.0
  • Depend on EF Core 5.0.0-preview3 for new annotations
  • Fix typo in type name

@roji roji requested a review from a team April 27, 2020 11:56
@roji roji force-pushed the SampleFixes branch 2 times, most recently from 23e9bf0 to eccade2 Compare April 27, 2020 12:15
@roji roji changed the title Fixes to samples to make them build Fixes to samples to make them build, plus Github Action to prevent breaks Apr 27, 2020
@ajcvickers
Copy link
Member

@roji I was planning a similar PR to this. Question: should we use the previews everywhere? Or only where the sample has 5.0 code?

@smitpatel
Copy link
Member

I think using preview for preview feature and latest stable for all others would be good compromise. It would also make sure we update our samples from 3.1 to 5.0 when we release 5.0, can catch some breaking changes in existing functionality if any. Also allows people downloading sample to not have preview setup unless they are trying out preview features.

@roji
Fixes to samples to make them build
af1ce31 
* Fix solution project reference
* Target netcoreapp3.1 instead of netcoreapp3.0
* Depend on EF Core 5.0.0-preview3 in DataAnnotations
* Fix typo in type name
@roji
Github Actions workflow to build the samples
d25b2f7
@roji
Copy link
Member Author

roji commented Apr 27, 2020

Changed to only depend on 5.0 preview3 in the DataAnnotations project which requires it.

@roji roji merged commit 804349c into master Apr 27, 2020
@roji roji deleted the SampleFixes branch April 27, 2020 18:08
@ajcvickers ajcvickers mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roji @ajcvickers @smitpatel