Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation page on collations and case-sensitivity #2328

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

roji
Copy link
Member

@roji roji commented Apr 27, 2020

The APIs in the samples will only appear in preview4 preview5, so we can't actually merge this until then.

Closes #2273

@roji roji force-pushed the Collations branch 6 times, most recently from 0b37ffc to 18903e0 Compare April 28, 2020 09:59
@roji roji requested a review from a team April 28, 2020 10:00
@roji roji force-pushed the Collations branch 2 times, most recently from 4f0ae57 to 7f5d0f5 Compare April 28, 2020 10:14
@roji roji marked this pull request as ready for review April 28, 2020 10:56
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.0-preview.3.20181.2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're too eager with your docs! ;-) These things aren't in preview 3...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's why this PR fails the build :) Just wanted to get this done with while everything is still fresh in mind.

We can hold off merging until preview4 is out...


* [SQL Server documentation on collations](https://docs.microsoft.com/sql/relational-databases/collations/collation-and-unicode-support).
* [Microsoft.Data.Sqlite documentation on collations](https://docs.microsoft.com/dotnet/standard/data/sqlite/collation).
* [PostgreSQL documentation on collations](https://www.postgresql.org/docs/current/collation.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced with an EFCore.PG provider doc page - the provider also supports index collations, and a database-level collation that propagates in EF Core, like identity (since the PostgreSQL support in CREATE DATABASE is unfortunately pretty bad).

@roji
Copy link
Member Author

roji commented May 20, 2020

@ajcvickers the EF.Functions.Collate support isn't in preview4 - I guess we should wait until preview5? Or do you think we should push a stripped-down version with it now?

@ajcvickers
Copy link
Member

@roji Either way is fine with me.

@roji
Copy link
Member Author

roji commented May 20, 2020

Then I say let's wait... Better to have the whole feature out. If someone asks, we can always point them to this PR...

Change depend on 5.0.0-preview5 where previews are needed.

Closes #2273
@roji roji merged commit 1441703 into master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document collation support and behavior around case-sensitivity
4 participants