Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to providers page #2410

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Updates to providers page #2410

merged 1 commit into from
Jun 1, 2020

Conversation

roji
Copy link
Member

@roji roji commented May 30, 2020

  • Update Oracle MySQL provider to 3.1 and bring up in the list
  • Update Oracle provider to 3.1 (specify beta) and bring up in the list
  • Update Devart providers from 3.0 to 3.1

* Update Oracle MySQL provider to 3.1 and bring up in the list
* Update Oracle provider to 3.1 (specify beta) and bring up in the list
* Update Devart providers from 3.0 to 3.1
Copy link
Member

@JeremyLikness JeremyLikness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "docs" words in the "useful links" column for the first 4 rows be removed because they aren't linking to anything? Those cells should probably be blank, no?

@roji
Copy link
Member Author

roji commented Jun 1, 2020

@JeremyLikness you're referring to the doc links for our providers, right (e.g. SQL Server)? If so, I think we recently agreed to put/move some provider-specific info there, so these pages should hopefully become more useful. We should probably beef those pages up regardless - we should probably add basic connection string/getting started examples for Sqlite, and a small section on Sqlite limitations compared to other databases...

@JeremyLikness
Copy link
Member

@roji it was my mistake. In the preview view the first four rows show "docs" without an active link, but I see they are using a directive that will get updated when the page is built. So, to amend my review comments: approved, no changes necessary. Nothing to see here, please move along.

@roji roji merged commit 7066a5e into master Jun 1, 2020
@smitpatel smitpatel deleted the UpdateProviders branch June 1, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants