Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for query splitting #2486

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Docs for query splitting #2486

merged 1 commit into from
Jul 7, 2020

Conversation

roji
Copy link
Member

@roji roji commented Jun 28, 2020

Part of #2479

@roji roji requested a review from a team June 28, 2020 22:16
@roji roji force-pushed the QuerySplitting branch 2 times, most recently from d6a196b to f469f63 Compare June 28, 2020 22:23
@roji roji marked this pull request as ready for review June 28, 2020 22:25

Unfortunately, there isn't one strategy for loading related entities that fits all scenarios. Carefully consider the advantages and disadvantages of single and split queries, and select the one that fits your needs.

> [!NOTE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know that we need this note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note on one-to-one navigations seems useful to help avoid confusion.. As for the rest, I'm just assuming lots of people will want the option to opt into split queries globally right away, so this is just there until we release it in a preview. I'll amend the text once that's out, hope that's reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants