Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description headers for all EF Core conceptual doc pages #2601

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Add description headers for all EF Core conceptual doc pages #2601

merged 1 commit into from
Sep 2, 2020

Conversation

roji
Copy link
Member

@roji roji commented Sep 1, 2020

No description provided.

@smitpatel
Copy link
Member

There are more descriptions to go. :trollface:

@roji roji force-pushed the DescribeThisForMe branch 2 times, most recently from 70cfaa2 to b16e9bf Compare September 1, 2020 17:38
@roji
Copy link
Member Author

roji commented Sep 1, 2020

@smitpatel addressed your comments, thanks. Did all EF6 descriptions too by simply copying the title and appending Entity Framework 6 as appropriate.

@roji roji marked this pull request as ready for review September 1, 2020 18:25
@smitpatel
Copy link
Member

Do you also want to fix the alt-text for img warning? Not many of those.

@roji
Copy link
Member Author

roji commented Sep 1, 2020

Sure, am already slogging through...

@roji
Copy link
Member Author

roji commented Sep 1, 2020

This way we get a warning-free doc build for like 5 minutes...

@smitpatel
Copy link
Member

Wait till I add CATS reporting again and find more warnings. :trollface:

@roji
Copy link
Member Author

roji commented Sep 1, 2020

I have 100% confidence in your warning generation capabilities 🤣

@roji roji merged commit ed2f590 into master Sep 2, 2020
@smitpatel smitpatel deleted the DescribeThisForMe branch September 2, 2020 21:33
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roji @smitpatel