Add some breaking changes #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
commented
Sep 9, 2020
entity-framework/core/what-is-new/ef-core-5.0/breaking-changes.md
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Sep 9, 2020
smitpatel
reviewed
Sep 9, 2020
smitpatel
approved these changes
Sep 9, 2020
AndriySvyryd
force-pushed
the
BreakingChanges
branch
from
7009949
to
83d417c
Compare
bricelam
reviewed
Sep 9, 2020
|
|
||
| **New behavior** | ||
|
|
||
| `IMigrationsModelDiffer` API now uses `IRelationalModel`. However the model snapshot still contains only `IModel` as this code is part of the application and Entity Framework can't change it without making a bigger breaking change. |
There was a problem hiding this comment.
We still have an issue to update the snapshot, right? I'd really like to do that if we can...
There was a problem hiding this comment.
You mean dotnet/efcore#18557? It would still be opt-in, so we'll have to support old snapshots for a while.
There was a problem hiding this comment.
Kind of... We could switch to new snapshots only having a RelationalModel but the default implementation could get it from any existing IModel. That command would just help "normalize" old migrations and snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2526
Fixes #2585
Fixes #2225
Fixes #2546