Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong code sample for AsSplitQuery/AsSingleQuery #2659

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

joakimriedel
Copy link
Contributor

Note - this is just raw edited in Github, have not verified locally that this will build and that the link will actually work. Hence draft pull request.

changed link to the right code sample
change region name (was duplicated)
@dnfadmin
Copy link

dnfadmin commented Sep 17, 2020

CLA assistant check
All CLA requirements met.

@joakimriedel
Copy link
Contributor Author

ping @roji how do I proceed with this? first time pull request, but found a small typo in the docs.

@joakimriedel
Copy link
Contributor Author

Found out how to test locally, this is ready for review.

@joakimriedel joakimriedel marked this pull request as ready for review September 18, 2020 08:10
@smitpatel smitpatel requested a review from roji September 18, 2020 15:14
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants