-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add start of ORM considerations #2668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖊️
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Co-authored-by: Shay Rojansky <roji@roji.org>
ms.date: 10/27/2016 | ||
description: General introductory overview of Entity Framework Core | ||
author: ajcvickers | ||
ms.date: 9/20/2020 | ||
uid: core/index | ||
--- | ||
|
||
# Entity Framework Core | ||
|
||
Entity Framework (EF) Core is a lightweight, extensible, [open source](https://github.com/aspnet/EntityFrameworkCore) and cross-platform version of the popular Entity Framework data access technology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong url!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still redirects
Is there a link to the finished ORM considerations document? I would like to link to it in my book. |
@JonPSmith It will be at https://docs.microsoft.com/ef/core/ when this is published. |
Can we merge to live now so it will be published? |
@roji - Please squash commits when merging to master in future. |
@ajcvickers @bricelam can we just force squashing on this repo like we do on the product repo? |
@roji Done. |
Thanks... Frankly, I wonder why it's not possible to just configure the default merge strategy, instead of having to disallow the others. All that is good excuses why we have 16 more commits in our repo history and it's not my fault |
@ajcvickers does that allow merge commits from master to live? The https://github.com/dotnet/AspNetCore.Docs repo requires merge commits to live. A default setting would be best. I could open a suggestion at GitHub. |
@smitpatel Thoughts on allowed commit settings? |
I use "automatically delete head branches" in all my repos - I think we discussed enabling this before, but maybe never did. Any objections to doing this? |
We can disable merge commits. Master to live requires merge commit but it is once every 2 week and generally not part of regular work-flow. I can deal with it via command line. Auto delete those branches after merge. In EF Core we have msft bot doing that. In docs, I generally trim it down. Automation would be useful. |
Should we disable the bot in the product repo now that it's a github-native feature? |
We do merge to live almost every day. We like to keep the published content fresh. |
I opened a feature request on GitHub |
GitHub response Hi Rick, Thanks for writing in. To clarify, what you’d like to see is either a specific merge method pre-selected or restricted which is configurable at the branch level to ensure the desired merge method is used based on the target branch? Eliminating the possibility of selecting a non-desired merge method? Given your use case, when merging pull requests to the master branch, you'd like to set the Squash and merge option set as the default behavior, and similarly, you'd like to select the Merge pull request option for pull requests to the live branch. If so, we do have an internal issue tracking similar feedback from customers requesting this functionality and I’d like to add your input to that discussion, please let me know if my understanding of your request is correct. Thanks, |
At least my perspective, there's no real need for this to be branch-specific - just a default merge strategy for the repo, much like it's already possible to disable merge strategies. In other words, I'd like to be able to make squashing the default strategy without disabling it. |
@roji that's what I suggested originally. I did update our suggestion:
|
First pass at #2106
Internal review URL
Apply MS style guide such as split up long sentences, use "For more information", ect.
Linking to the
## EF ORM considerations
section will be beneficial to EF docs in other repositories.