Update Spatial docs #2723
Update Spatial docs #2723
Conversation
|
I was just surprised that Brice wrote 9,700 lines worth of content in docs. 😮 |
|
lol, that JSON file is pretty big. I'll reduce it. |
|
|
||
| By default, spatial properties are mapped to `geography` columns in SQL Server. To use `geometry`, [configure the column type](xref:core/modeling/entity-properties#column-data-types) in your model. | ||
|
|
||
| ## Geography polygon rings |
There was a problem hiding this comment.
Should this be a lower-level heading?
There was a problem hiding this comment.
I don't think so, it's not really related to choosing between geometry or geography
| @@ -23,22 +23,19 @@ Microsoft.EntityFrameworkCore.SqlServer | [Microsoft.EntityFrameworkCore.SqlServ | |||
| Microsoft.EntityFrameworkCore.Sqlite | [Microsoft.EntityFrameworkCore.Sqlite.NetTopologySuite](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Sqlite.NetTopologySuite) | |||
There was a problem hiding this comment.
Can remove the 'EF Core 2.2' note
Should we add a column for the first version where spatial is supported for each provider?
There was a problem hiding this comment.
I want to keep the 2.2 note until 2.1 goes out of support. All providers work on EF Core 3.1.
| @@ -233,6 +233,9 @@ | |||
| href: core/providers/sql-server/indexes.md | |||
| - name: Memory-optimized tables | |||
| href: core/providers/sql-server/memory-optimized-tables.md | |||
| - name: Spatial data | |||
| displayName: GIS | |||
There was a problem hiding this comment.
Should we leave spatial data as the display name? Am just not sure everyone knows the name GIS. Not sure.
There was a problem hiding this comment.
We should add Spatial Data too for localization.
There was a problem hiding this comment.
lol, displayName has nothing to do with the displayed name. (But I can certainly see why you might think that.) It's for additional keywords users can search for:
Fixes dotnet#1118, fixes dotnet#2352, fixes dotnet#2611, fixes dotnet#2674
Fixes #1118, fixes #2352, fixes #2611, fixes #2674