-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docs for context creation and initialization #2849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
NewsFactory1107
branch
3 times, most recently
from
November 9, 2020 00:32
c683592
to
4ba6238
Compare
@dotnet/efteam Not ready to merge yet, but ready for feedback. |
@smitpatel After releases and planning. |
also check links at the bottom of \core\cli\dbcontext-creation.md |
ajcvickers
force-pushed
the
NewsFactory1107
branch
from
November 9, 2020 23:54
a1a778d
to
c595e2e
Compare
@dotnet/efteam This is now ready for full review. |
ajcvickers
force-pushed
the
NewsFactory1107
branch
from
November 10, 2020 00:18
096dc6f
to
52b2126
Compare
AndriySvyryd
approved these changes
Nov 10, 2020
Fixes #594 Part of #876 Fixes #1390 Fixes #1923 Fixes #2241 Part of #2523 Part of #2549 Part of #1832 Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail: - DbContext lifetime, configuration and initialization - Overview - Connection strings - Using dependency injection - Connection resiliency - Context pooling New docs for context creation and initialization
ajcvickers
force-pushed
the
NewsFactory1107
branch
from
November 11, 2020 20:22
52b2126
to
e1e55b4
Compare
ajcvickers
force-pushed
the
NewsFactory1107
branch
2 times, most recently
from
November 11, 2020 20:35
dc30743
to
6a75c4e
Compare
ajcvickers
force-pushed
the
NewsFactory1107
branch
from
November 11, 2020 20:37
6a75c4e
to
53826ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832
Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail: