Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs for context creation and initialization #2849

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Conversation

ajcvickers
Copy link
Member

Draft

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

  • DbContext lifetime, configuration and initialization
    • Overview
    • Connection strings
    • Using dependency injection
    • Connection resiliency
    • Context pooling

@ajcvickers ajcvickers marked this pull request as draft November 9, 2020 00:10
@ajcvickers ajcvickers force-pushed the NewsFactory1107 branch 3 times, most recently from c683592 to 4ba6238 Compare November 9, 2020 00:32
@ajcvickers ajcvickers requested a review from a team November 9, 2020 00:41
@ajcvickers
Copy link
Member Author

@dotnet/efteam Not ready to merge yet, but ready for feedback.

@smitpatel
Copy link
Member

smitpatel commented Nov 9, 2020

Where will this section go in top level?
Currently planned tree
image

@ajcvickers
Copy link
Member Author

@smitpatel After releases and planning.

@smitpatel
Copy link
Member

also check links at the bottom of \core\cli\dbcontext-creation.md

@ajcvickers ajcvickers marked this pull request as ready for review November 10, 2020 00:10
@ajcvickers
Copy link
Member Author

@dotnet/efteam This is now ready for full review.

Fixes #594
Part of #876
Fixes #1390
Fixes #1923
Fixes #2241
Part of #2523
Part of #2549
Part of #1832

Let's discuss where this page should go and what goes underneath it. We had previously decided to keep this in Miscellaneous, but I now believe this would be better as a top-level item with the following subsections to go into more detail:

- DbContext lifetime, configuration and initialization
  - Overview
  - Connection strings
  - Using dependency injection
  - Connection resiliency
  - Context pooling

New docs for context creation and initialization
@ajcvickers ajcvickers force-pushed the NewsFactory1107 branch 2 times, most recently from dc30743 to 6a75c4e Compare November 11, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants