Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix break in tests from VS 17.3 #805

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Fix break in tests from VS 17.3 #805

merged 2 commits into from
Sep 5, 2022

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Sep 5, 2022

This is a workaround suggested in dotnet/msbuild#7873

@AArnott AArnott added this to the v3.6 milestone Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Base: 81.43% // Head: 77.31% // Decreases project coverage by -4.12% ⚠️

Coverage data is based on head (b6d0df4) compared to base (538af29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
- Coverage   81.43%   77.31%   -4.13%     
==========================================
  Files          73       73              
  Lines        3830     3830              
==========================================
- Hits         3119     2961     -158     
- Misses        711      869     +158     
Impacted Files Coverage Δ
.../Nerdbank.GitVersioning.Tasks/NativeVersionInfo.cs 0.00% <0.00%> (-85.48%) ⬇️
src/Nerdbank.GitVersioning.Tasks/AssemblyLoader.cs 0.00% <0.00%> (-53.85%) ⬇️
...c/NerdBank.GitVersioning/ManagedGit/FileHelpers.cs 48.48% <0.00%> (-51.52%) ⬇️
...c/Nerdbank.GitVersioning.Tasks/ContextAwareTask.cs 68.96% <0.00%> (-24.14%) ⬇️
...erdbank.GitVersioning.Tasks/AssemblyVersionInfo.cs 62.71% <0.00%> (-6.50%) ⬇️
src/NerdBank.GitVersioning/ManagedGit/GitPack.cs 86.44% <0.00%> (-1.70%) ⬇️
...Bank.GitVersioning/LibGit2/LibGit2GitExtensions.cs 91.87% <0.00%> (-1.02%) ⬇️
...rc/Nerdbank.GitVersioning.Tasks/GetBuildVersion.cs 90.51% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AArnott AArnott merged commit 6fb1f18 into main Sep 5, 2022
@AArnott AArnott deleted the fixbuildbreak_main branch September 5, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant