CertificateTests are broken #2805
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
==========================================
- Coverage 71.66% 71.59% -0.07%
==========================================
Files 308 308
Lines 62297 62297
==========================================
- Hits 44646 44604 -42
- Misses 17651 17693 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpeningConnectionWitHNICTest and OpenningConnectionWithGoodCertificateTest are both broken and fail if the TCPConnectionString doesn't include TrustServerCertificate=true. The tests are supposed to install a self-signed certificate to the localhost SQL Server instance and add it to the root cert store so that it is trusted by the system. But it doesn't work and needs to be fixed.
RemoteCertificateNameMismatchErrorTest was already flagged as an active issue (26934), but I can't find that issue number anywhere, so updating that number to include in the new issue I filed internally.