[debugger] Componentize the debugger, only link debugger when it's a debug app. #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <AndroidLinkMode Condition=" '$(AndroidLinkMode)' == '' ">None</AndroidLinkMode> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> | ||
| <AndroidEnableDebugger Condition=" '$(AndroidEnableDebugger)' == ''">false</AndroidEnableDebugger> |
There was a problem hiding this comment.
There is another property $(AndroidUseDebugRuntime):
It's based on $(Optimize):
Should we use that instead of making a new property?
There was a problem hiding this comment.
If you prefer to reuse something I think that we should reuse: AndroidIncludeDebugSymbols
There was a problem hiding this comment.
What do you think about it?
There was a problem hiding this comment.
Yes, $(AndroidIncludeDebugSymbols) seems right, because it also looks at $(DebugType):
grendello
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for release app will be false, so debugger will not be available.
The default value for release app will be true, so debugger will be available.
Related to dotnet/runtime#54887