Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] implement $(AndroidStripILAfterAOT) #8172

Merged
merged 14 commits into from
Aug 22, 2023
Merged

[Xamarin.Android.Build.Tasks] implement $(AndroidStripILAfterAOT) #8172

merged 14 commits into from
Aug 22, 2023

Commits on Jul 6, 2023

  1. [Xamarin.Android.Build.Tasks] implement $(AndroidStripIL) 

    Context: dotnet/runtime#86722

This adds an `<ILStrip/>` step after the `<MonoAOTCompiler/>` task.

This trims away IL of AOT-compiled methods. This is WIP.

Builds work currently, but the app crashes at runtime with:

    07-06 16:57:07.413  8865  8865 E companyname.foo: * Assertion at /__w/1/s/src/mono/mono/mini/mini-trampolines.c:1416, condition `invoke' not met
    @jonathanpeppers
    jonathanpeppers committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    815e374 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Update parameter names

    @fanyang-mono
    fanyang-mono committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2d8bfff View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Disable removing attribute when AndroidStripIL is enanbled.

    @fanyang-mono
    fanyang-mono committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d0db340 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'origin/main' into peppers/AndroidStripIL

    @fanyang-mono
    fanyang-mono committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f747395 View commit details
    Browse the repository at this point in the history

  2. Add a test

    @fanyang-mono
    fanyang-mono committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    19b2ab9 View commit details
    Browse the repository at this point in the history

  3. Set default parameter values

    @fanyang-mono
    fanyang-mono committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6152320 View commit details
    Browse the repository at this point in the history

  4. Add documentation of the new feature

    @fanyang-mono
    fanyang-mono committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0feee89 View commit details
    Browse the repository at this point in the history

  5. Simpler default for AndroidEnableProfiledAot

    @jonathanpeppers
    jonathanpeppers committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    747aabc View commit details
    Browse the repository at this point in the history

  6. AndroidStripIL can default to empty

    @jonathanpeppers
    jonathanpeppers committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0902fea View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Update parameter name

    @fanyang-mono
    fanyang-mono committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6ac4b46 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Update build-properties.md 

    Rewrite for consistency with the "flow" of other properties.
    @jonpryor
    jonpryor committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    647c8b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into AndroidStripIL

    @jonathanpeppers
    jonathanpeppers committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b5dc596 View commit details
    Browse the repository at this point in the history

  3. EnableAndroidStripILAfterAOT asserts IL is stripped 

    `HasBody` was true and `Body.Instructions.Count` was 0
    @jonathanpeppers
    jonathanpeppers committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e4db7b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. $(AndroidEnableProfiledAot) test parameter

    @jonathanpeppers
    jonathanpeppers committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    40475e2 View commit details
    Browse the repository at this point in the history