Making ConvertPortablePdbsToWindowsPdbs settable (#8096)

* Making ConvertPortablePdbsToWindowsPdbs settable * added comments
dotnet · Oct 26, 2021 · e3141f8 · e3141f8
1 parent 42bafbb
commit e3141f8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishArtifactsInManifest.proj
@@ -69,6 +69,8 @@
           - InternalInstallersTargetStaticFeedKey
           - InternalChecksumsTargetStaticFeed
           - InternalChecksumsTargetStaticFeedKey
+
+    NOTE: For symbol publishing using V3, ConvertPortablePdbsToWindowsPdbs is always set to false, because this is an expensive task so this is done in the staging pipeline post signing.
   -->
 
   <PropertyGroup>

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishToSymbolServers.proj b/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/PublishToSymbolServers.proj
@@ -37,6 +37,9 @@
       <PackagesToPublishToSymbolServer Remove="$(BlobBasePath)\Microsoft.DotNet.Maestro.Tasks.*" />
     </ItemGroup>
 
+    <!--
+    ConvertPortablePdbsToWindowsPdbs is set to true only in staging pipeline, because this is an expensive task and we don't want to do it for every build.
+    -->
     <PropertyGroup>
       <DotNetSymbolExpirationInDays Condition="'$(DotNetSymbolExpirationInDays)' == ''">3650</DotNetSymbolExpirationInDays>
       <PublishToSymbolServer>true</PublishToSymbolServer>
@@ -45,6 +48,7 @@
       <PublishToSymbolServer Condition="'@(FilesToPublishToSymbolServer)' == '' and '@(PackagesToPublishToSymbolServer)' == ''">false</PublishToSymbolServer>
       <PublishSpecialClrFiles Condition="'$(PublishSpecialClrFiles)' == ''">true</PublishSpecialClrFiles>
       <DryRun Condition="'$(DryRun)' == ''">false</DryRun>
+      <ConvertPortablePdbsToWindowsPdbs Condition="'$(ConvertPortablePdbsToWindowsPdbs)' == ''">false</ConvertPortablePdbsToWindowsPdbs>
     </PropertyGroup>
 
     <Message
@@ -98,7 +102,7 @@
                     ExpirationInDays="$(DotNetSymbolExpirationInDays)"
                     VerboseLogging="true"
                     DryRun="$(DryRun)"
-                    ConvertPortablePdbsToWindowsPdbs="false"
+                    ConvertPortablePdbsToWindowsPdbs="$(ConvertPortablePdbsToWindowsPdbs)"
                     PdbConversionTreatAsWarning=""
                     PublishSpecialClrFiles="$(PublishSpecialClrFiles)"
                     Condition="$(PublishToSymbolServer)"/>

diff --git a/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs b/src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
@@ -494,6 +494,8 @@ await DownloadFileAsync(
 
                                 try
                                 {
+                                    // ConvertPortablePdbsToWindowsPdbs is always set to false, 
+                                    // because this is an expensive task so this is done in the staging pipeline post signing.
                                     await PublishSymbolsHelper.PublishAsync(
                                         Log,
                                         serverPath,
@@ -560,6 +562,8 @@ await PublishSymbolsHelper.PublishAsync(
 
                     try
                     {
+                        // ConvertPortablePdbsToWindowsPdbs is always set to false,
+                        // because this is an expensive task so this is done in the staging pipeline post signing.
                         await PublishSymbolsHelper.PublishAsync(
                             Log,
                             serverPath,
@@ -686,6 +690,8 @@ public async Task PublishSymbolsfromBlobArtifactsAsync(
 
                     try
                     {
+                        // ConvertPortablePdbsToWindowsPdbs is always set to false,
+                        // because this is an expensive task so this is done in the staging pipeline post signing.
                         await PublishSymbolsHelper.PublishAsync(
                             Log,
                             serverPath,