Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL validation failing with "Invalid Guardian CLI Location" #8243

Closed
michellemcdaniel opened this issue Dec 6, 2021 · 3 comments
Closed
Assignees

Comments

@michellemcdaniel
Copy link
Contributor

In the staging/validation pipeline, our sdl validation is failing with the above error post-guardian upgrade.

@michellemcdaniel michellemcdaniel self-assigned this Dec 6, 2021
michellemcdaniel added a commit to michellemcdaniel/arcade that referenced this issue Dec 7, 2021
SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing.

This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.
@michellemcdaniel
Copy link
Contributor Author

This will have 3 PRs: the first is https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/20198 (to fix this issue for now).

The last two will be split between an arcade PR: #8247 (to move shared steps/variables to their own templates) and a dotnet-release PR, once that change has promoted, to switch to using the new shared templates.

michellemcdaniel added a commit that referenced this issue Dec 7, 2021
* Move common parts of sdl templates to additional templates

SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like #8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing.

This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.

* Fix typo
@michellemcdaniel
Copy link
Contributor Author

@michellemcdaniel
Copy link
Contributor Author

PR is complete

garath pushed a commit to garath/dotnet-arcade that referenced this issue Mar 1, 2022
* Move common parts of sdl templates to additional templates

SDL Validation is done in both the repos and the staging/validaiton pipelines. Today, we have a large amount of the sdl job template duplicated for the staging/validation pipelines because we need to use different sources/we don't need all the artifact downloading (and if we did, we would want to get the artifacts from a different place). This duplication leads to issues like dotnet#8243 (among others), where versions changed in arcade, but they weren't properly migrated to dotnet-release, and the validation pipeline started failing.

This change moves the duplicated steps to a steps template, and the duplicated variables to a variables template, so we can more easily share between these repos/pipelines.

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant