Merge automation: link to config file #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
commented
Oct 23, 2020
scripts/GitHubMergeBranches.ps1
Outdated
| @@ -351,7 +351,7 @@ You may need to fix this problem by merging branches with this PR. Contact .NET | |||
| } | |||
|
|
|||
| $prBody = @" | |||
| I detected changes in the $HeadBranch branch which have not been merged yet to $BaseBranch. I'm a robot and am configured to help you automatically keep $BaseBranch up to date, so I've opened this PR. | |||
| I detected changes in the $HeadBranch branch which have not been merged yet to $BaseBranch. I'm a robot and am [configured](https://github.com/dotnet/versions/blob/master/Maestro/subscriptions.json) to help you automatically keep $BaseBranch up to date, so I've opened this PR. | |||
There was a problem hiding this comment.
Link here too subtle? Could also be a separate line, but there's a lot in the PR body already . . .
There was a problem hiding this comment.
Hmm. Well, this PR is easy to approve for merge since it's fairly minimally adding a useful link to a word where it makes sense, but yeah, I'm not sure this will stand out to people who don't know what they're looking for. And more context could be useful too for people who don't know the subscriptions file is meant for anyone to submit PRs against.
dagood
approved these changes
Oct 23, 2020
Link to the file that defines the merge configuration in merge PRs. Fixes dotnet#6409.
rainersigwald
force-pushed
the
url-in-merge-prs
branch
from
1c3faba
to
ed64d31
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the file that defines the merge configuration in merge PRs.
Fixes #6409.