Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if AzdoApiToken or ArtifactsBasePath are empty if UseStreamingPublishing is false #7308

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Don't fail if AzdoApiToken or ArtifactsBasePath are empty if UseStreamingPublishing is false #7308

merged 1 commit into from
Apr 28, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Apr 28, 2021

These are not required if not using streaming publishing, as is the case when publishing post-build signed assets

To double check:

@mmitche
Don't fail if AzdoApiToken or ArtifactsBasePath are empty if UseStrea…
ad77ca2 
…mingPublishing is false

These are not required if not using streaming publishing, as is the case when publishing post-build signed assets
@mmitche mmitche merged commit 7736546 into dotnet:main Apr 28, 2021
@mmitche mmitche deleted the dontfailonsomemissingprops branch April 28, 2021 19:41
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellemcdaniel michellemcdaniel michellemcdaniel approved these changes

@epananth epananth epananth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @michellemcdaniel @epananth