Disable windows pdb verification by default #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we publish symbols, they are published without windows pdb conversion. This happens on release day Avoid checking for windows PDBs by default. Still available via switch.
| @@ -204,41 +212,41 @@ function CheckSymbolsAvailable { | |||
| $DupedSymbols = 0 | |||
|
|
|||
| Get-ChildItem "$InputPath\*.nupkg" | | |||
| ForEach-Object { | |||
There was a problem hiding this comment.
Why are we changing the indentation here?
There was a problem hiding this comment.
It was very difficult to track down the script blocks that had to be altered because the formatting was pretty wacky. So I ran it through the formatter. You can use "Hide whitespace changes" to see just the lines that changed.
There was a problem hiding this comment.
Right, but I think that's indented that way because of the piping. ie Get-ChildItem is being piped into the ForEach-Object, so I think that indentation was intentional.
michellemcdaniel
approved these changes
Apr 28, 2021
|
Hello @mmitche! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we publish symbols, they are published without windows pdb conversion. This happens on release day
Avoid checking for windows PDBs by default. Still available via switch.
Also run the formatter on the code, as it was really hard to figure out the scoping of various blocks due to indentation.
To double check: