Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the remote executor tests #7321

Merged
merged 1 commit into from
May 3, 2021
Merged

Skip the remote executor tests #7321

merged 1 commit into from
May 3, 2021

Conversation

alexperovich
Copy link
Member

@alexperovich alexperovich commented Apr 29, 2021 •
edited
Loading

@alexperovich alexperovich self-assigned this Apr 29, 2021
MattGal
MattGal reviewed Apr 29, 2021
View reviewed changes
src/Microsoft.DotNet.RemoteExecutor/tests/RemoteExecutorTests.cs
using Xunit.Sdk;

namespace Microsoft.DotNet.RemoteExecutor.Tests
{
public class RemoteExecutorTests
{
[Fact]
[Fact(Skip = "Remote executor is broken in VS test explorer")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this not disable it from normal console execution?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that even possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its only possible by basically rewriting swaths of xunit to make a custom Fact attribute.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought runtime did this all the time using some kind of extension pattern. Just seems like perma-skip = never run and I understand they pass outside of VS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime has a huge swath of custom fact stuff that I don't think we want to duplicate just to deal with these handful of tests. :-)

@alexperovich
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexperovich alexperovich merged commit a7291d7 into dotnet:main May 3, 2021
@alexperovich alexperovich deleted the disableRemoteExectuorTests branch May 3, 2021 18:53
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal left review comments

@ChadNedzlek ChadNedzlek ChadNedzlek approved these changes

@jakubstilec jakubstilec jakubstilec approved these changes

@riarenas riarenas Awaiting requested review from riarenas

Assignees

@alexperovich alexperovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexperovich @jakubstilec @MattGal @ChadNedzlek