Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use msbuild logging for symbol messages #7352

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 6, 2021

Because the symbol upload internally uses the msbuild loggers, if this code uses a string builder and then prints all the info at the end, the binlog tends to look like:

symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 3
symbol upload diagnostic for symbol package 3
...
top level upload info for 1
top level upload info for 2
top level upload info for 3

Instead, it's easier to read as:

top level upload info for 1
symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 1
top level upload info for 2
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 2
top level upload info for 3
symbol upload diagnostic for symbol package 3
symbol upload diagnostic for symbol package 3

There will be some interleaving due to parallelism, but right now it's difficult to line up the top level messages with the diagnostic ones.

To double check:

Because the symbol upload internally uses the msbuild loggers, if this code uses a string builder and then prints all the info at the end, the binlog tends to look like:

symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 3
symbol upload diagnostic for symbol package 3
...
top level upload info for 1
top level upload info for 2
top level upload info for 3

Instead, it's easier to read as:

top level upload info for 1
symbol upload diagnostic for symbol package 1
symbol upload diagnostic for symbol package 1
top level upload info for 2
symbol upload diagnostic for symbol package 2
symbol upload diagnostic for symbol package 2
top level upload info for 3
symbol upload diagnostic for symbol package 3
symbol upload diagnostic for symbol package 3

There will be some interleaving due to parallelism, but right now it's difficult to line up the top level messages with the diagnostic ones.
@mmitche
Copy link
Member Author

mmitche commented May 6, 2021

@epananth I can wait till your stuff goes in to avoid merge conflicts.

@epananth
Copy link
Member

epananth commented May 6, 2021

Yes, Still building. Will merge it soon and let you know..

@epananth
Copy link
Member

epananth commented May 6, 2021

I merged my changes.

@mmitche mmitche requested a review from epananth May 12, 2021 17:35
@epananth epananth merged commit 57707a9 into dotnet:main May 12, 2021
@mmitche mmitche deleted the log-interleaved branch February 9, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants