Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily move publishing to Helix build agents #7404

Merged
merged 1 commit into from
May 25, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented May 18, 2021

As seen in https://github.com/dotnet/core-eng/issues/13098 and the linked IcM ticket, we seem to have moved from WIN- to fv- machines and started hitting memory issues.

To double check:

As seen in dotnet/core-eng#13098 and the linked IcM ticket, we seem to have moved from WIN- to fv- machines and started hitting memory issues.
@MattGal MattGal requested a review from epananth May 18, 2021 22:47
@riarenas
Copy link
Member

Do we have the capacity for this? 😮

@MattGal
Copy link
Member Author

MattGal commented May 18, 2021

Do we have the capacity for this? 😮

Pretty sure in terms of cores and agent capacity we do, other than if you mean monetarily where I have no clue. This is way more expensive than using hosted since it's moving around ADO artifacts. I am simply preparing the PR to have it ready if we want to; it might be something we do via a custom non-main branch like before when the problem was disk space not memory.

@riarenas
Copy link
Member

riarenas commented May 18, 2021

Yep makes sense. Was mostly worried about cores and wait times.

Maybe this is a good opportunity for another major overhaul for how we do the publishing. I'm sure @epananth would appreciate that. (not)

@MattGal MattGal merged commit 579b548 into main May 25, 2021
@mmitche mmitche deleted the workaround-fv-class-ooms branch March 3, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants